Skip to content

Implementing report running state in lifecycle manager#55

Merged
ramceb merged 10 commits intoeclipse-score:mainfrom
Valeo-S-CORE-Organization:Implement_report_running_state
Mar 4, 2026
Merged

Implementing report running state in lifecycle manager#55
ramceb merged 10 commits intoeclipse-score:mainfrom
Valeo-S-CORE-Organization:Implement_report_running_state

Conversation

@shegazyy
Copy link
Contributor

@shegazyy shegazyy commented Feb 2, 2026 •
edited
Loading

Implementing report running state in lifecycle manager as per discussion with @NicolasFussberger on slack.

@shegazyy shegazyy temporarily deployed to workflow-approval February 2, 2026 13:50 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 2, 2026 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: 8c655e92-23ab-4d4b-b99a-0463f1d7d2ae
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (24 packages loaded, 9 targets configured)

Analyzing: target //:license-check (34 packages loaded, 9 targets configured)

Analyzing: target //:license-check (77 packages loaded, 9 targets configured)

Analyzing: target //:license-check (125 packages loaded, 768 targets configured)

Analyzing: target //:license-check (133 packages loaded, 4345 targets configured)

Analyzing: target //:license-check (134 packages loaded, 7201 targets configured)

Analyzing: target //:license-check (145 packages loaded, 7267 targets configured)

Analyzing: target //:license-check (145 packages loaded, 7267 targets configured)

Analyzing: target //:license-check (148 packages loaded, 9277 targets configured)

Analyzing: target //:license-check (149 packages loaded, 9401 targets configured)

INFO: Analyzed target //:license-check (150 packages loaded, 9527 targets configured).
[11 / 13] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[12 / 13] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 30.574s, Critical Path: 2.42s
INFO: 13 processes: 9 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

The created documentation from the pull request is available at: docu-html

@NicolasFussberger
Copy link
Contributor

NicolasFussberger commented Feb 3, 2026

Changes look good to me👍
One idea would be to adapt the example at

lifecycle/examples/cpp_lifecycle_app/main.cpp

Line 134 in c7d58e9

score::lcm::LifecycleClient{}.ReportExecutionState(score::lcm::ExecutionState::kRunning);
to see this also working in running code.

We can then reuse this example app for an automated integration test.

@shegazyy shegazyy temporarily deployed to workflow-approval February 3, 2026 13:12 — with GitHub Actions Inactive
@shegazyy shegazyy temporarily deployed to workflow-approval February 5, 2026 15:08 — with GitHub Actions Inactive
@shegazyy shegazyy temporarily deployed to workflow-approval February 8, 2026 11:36 — with GitHub Actions Inactive
@shegazyy shegazyy temporarily deployed to workflow-approval February 8, 2026 11:38 — with GitHub Actions Inactive
@shegazyy shegazyy force-pushed the Implement_report_running_state branch from a70ccde to 5b0b39e Compare February 8, 2026 13:23
@shegazyy shegazyy temporarily deployed to workflow-approval February 8, 2026 13:23 — with GitHub Actions Inactive
NicolasFussberger
NicolasFussberger reviewed Feb 11, 2026
View reviewed changes
@shegazyy shegazyy temporarily deployed to workflow-approval February 16, 2026 15:20 — with GitHub Actions Inactive
@shegazyy shegazyy temporarily deployed to workflow-approval February 16, 2026 15:20 — with GitHub Actions Inactive
@NicolasFussberger
Copy link
Contributor

NicolasFussberger commented Feb 18, 2026

I cannot build it and test it right now due to a build problem coming from mw::log, but all changes look good to me.

ramceb
ramceb approved these changes Mar 4, 2026
View reviewed changes
Copy link
Contributor

@ramceb ramceb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on approval form @NicolasFussberger

@ramceb ramceb merged commit 0d56bee into eclipse-score:main Mar 4, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramceb ramceb ramceb approved these changes

+1 more reviewer

@NicolasFussberger NicolasFussberger NicolasFussberger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shegazyy @NicolasFussberger @ramceb